s3: Assigning ?True:False to a bool is a bit pointless

Signed-off-by: Michael Adam <obnox@samba.org>

diff --git a/source3/smbd/open.c b/source3/smbd/open.c
index a098124618b396f5fe113f766871541e96def649..d5fba4db192f41eb8d179d025a66bd11c5842fce 100644 (file)
--- a/source3/smbd/open.c
+++ b/source3/smbd/open.c
@@ -776,12 +776,11 @@ static NTSTATUS open_file(files_struct *fsp,
        fsp->vuid = req ? req->vuid : UID_FIELD_INVALID;
        fsp->file_pid = req ? req->smbpid : 0;
        fsp->can_lock = True;
-       fsp->can_read = (access_mask & FILE_READ_DATA) ? True : False;
+       fsp->can_read = ((access_mask & FILE_READ_DATA) != 0);
        if (!CAN_WRITE(conn)) {
                fsp->can_write = False;
        } else {
-               fsp->can_write = (access_mask & (FILE_WRITE_DATA | FILE_APPEND_DATA)) ?
-                       True : False;
+               fsp->can_write = ((access_mask & (FILE_WRITE_DATA | FILE_APPEND_DATA)) != 0);
        }
        fsp->print_file = NULL;
        fsp->modified = False;