Check for -1.
authorJelmer Vernooij <jelmer@jelmer.uk>
Fri, 25 May 2018 17:58:07 +0000 (18:58 +0100)
committerJelmer Vernooij <jelmer@jelmer.uk>
Fri, 25 May 2018 17:58:07 +0000 (18:58 +0100)
subvertpy/util.c

index ef52cacdb09adbe5b96cc6fbbf62c1f09e1b0ff4..8fe7407aaf2fad573fff0c995e76f6fb8beb01e8 100644 (file)
@@ -580,7 +580,7 @@ apr_hash_t *prop_dict_to_hash(apr_pool_t *pool, PyObject *py_props)
                        Py_INCREF(v);
                }
 
-               if (PyBytes_AsStringAndSize(k, &key, &key_size)) {
+               if (PyBytes_AsStringAndSize(k, &key, &key_size) == -1) {
                        PyErr_SetString(PyExc_TypeError,
                                                        "property key should be unicode or byte string");
                        Py_DECREF(k);
@@ -588,7 +588,7 @@ apr_hash_t *prop_dict_to_hash(apr_pool_t *pool, PyObject *py_props)
                        return NULL;
                }
 
-               if (PyBytes_AsStringAndSize(v, &val, &val_size)) {
+               if (PyBytes_AsStringAndSize(v, &val, &val_size) == -1) {
                        PyErr_SetString(PyExc_TypeError,
                                                        "property value should be unicode or byte string");
                        Py_DECREF(k);