r14249: We've dereferenced the_acl before, no point in checking.

Fix Coverity bug # 128.

Volker

diff --git a/source/lib/secdesc.c b/source/lib/secdesc.c
index a443f90dbb4aaeebaa823f9d43e8ba9b1349f40d..11f963fa0e86da4b9ea0ad64af2810de8570ecce 100644 (file)
--- a/source/lib/secdesc.c
+++ b/source/lib/secdesc.c
@@ -433,7 +433,7 @@ SEC_DESC_BUF *se_create_child_secdesc(TALLOC_CTX *ctx, SEC_DESC *parent_ctr,
        if (!(new_ace_list = TALLOC_ARRAY(ctx, SEC_ACE, the_acl->num_aces))) 
                return NULL;
 
-       for (i = 0; the_acl && i < the_acl->num_aces; i++) {
+       for (i = 0; i < the_acl->num_aces; i++) {
                SEC_ACE *ace = &the_acl->ace[i];
                SEC_ACE *new_ace = &new_ace_list[new_ace_list_ndx];
                uint8 new_flags = 0;