libcli:auth: Return NTSTATUS for netlogon_creds_client_authenticator()
authorAndreas Schneider <asn@samba.org>
Wed, 13 Nov 2019 08:52:53 +0000 (09:52 +0100)
committerAndreas Schneider <asn@cryptomilk.org>
Thu, 14 Nov 2019 08:01:44 +0000 (08:01 +0000)
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14195

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
libcli/auth/credentials.c
libcli/auth/proto.h

index 359ba8c4b90e1cf13834bc4a301f0b0439f1350d..e5bf2c4703cfd3cb458cfd29e0036510690edd91 100644 (file)
@@ -513,8 +513,9 @@ struct netlogon_creds_CredentialState *netlogon_creds_client_init_session_key(TA
   produce the next authenticator in the sequence ready to send to
   the server
 */
-void netlogon_creds_client_authenticator(struct netlogon_creds_CredentialState *creds,
-                               struct netr_Authenticator *next)
+NTSTATUS
+netlogon_creds_client_authenticator(struct netlogon_creds_CredentialState *creds,
+                                   struct netr_Authenticator *next)
 {
        uint32_t t32n = (uint32_t)time(NULL);
 
@@ -543,6 +544,8 @@ void netlogon_creds_client_authenticator(struct netlogon_creds_CredentialState *
 
        next->cred = creds->client;
        next->timestamp = creds->sequence;
+
+       return NT_STATUS_OK;
 }
 
 /*
index 52a33d8d4578f07cf6314abe844ab29008d5cf87..eef1c8dc09520f2b6eef994ce3553d60c2723395 100644 (file)
@@ -40,8 +40,9 @@ struct netlogon_creds_CredentialState *netlogon_creds_client_init(TALLOC_CTX *me
                                                                  uint32_t negotiate_flags);
 struct netlogon_creds_CredentialState *netlogon_creds_client_init_session_key(TALLOC_CTX *mem_ctx, 
                                                                              const uint8_t session_key[16]);
-void netlogon_creds_client_authenticator(struct netlogon_creds_CredentialState *creds,
-                               struct netr_Authenticator *next);
+NTSTATUS
+netlogon_creds_client_authenticator(struct netlogon_creds_CredentialState *creds,
+                                   struct netr_Authenticator *next);
 bool netlogon_creds_client_check(struct netlogon_creds_CredentialState *creds,
                        const struct netr_Credential *received_credentials);
 struct netlogon_creds_CredentialState *netlogon_creds_copy(