cifs.idmap: make sure cifsacl structs are packed

The kernel equivalent definitions are defined with
__attribute__((packed)), and the code seems to assume the userspace and
kernel ones will be properly aligned. Fix the userspace definitions in a
similar fashion.

Given the way these structs are, there is probably not any padding
between fields on most arches, but it's best to be safe here.

Reviewed-by: Shirish Pargaonkar <shirishpargaonkar@gmail.com>
Signed-off-by: Jeff Layton <jlayton@samba.org>

diff --git a/cifsacl.h b/cifsacl.h
index 4ea7fd47f26d1fa888343a42fa0a88b7f1f36f10..101881b7e2534000cc01e36cc1aaa27084a0550d 100644 (file)
--- a/cifsacl.h
+++ b/cifsacl.h
@@ -110,20 +110,20 @@ struct cifs_ntsd {
        uint32_t gsidoffset;
        uint32_t sacloffset;
        uint32_t dacloffset;
-};
+} __attribute__((packed));
 
 struct cifs_sid {
        uint8_t revision; /* revision level */
        uint8_t num_subauth;
        uint8_t authority[6];
        uint32_t sub_auth[5]; /* sub_auth[num_subauth] */
-};
+} __attribute__((packed));
 
 struct cifs_ctrl_acl {
        uint16_t revision; /* revision level */
        uint16_t size;
        uint32_t num_aces;
-};
+} __attribute__((packed));
 
 struct cifs_ace {
        uint8_t type;
@@ -131,6 +131,6 @@ struct cifs_ace {
        uint16_t size;
        uint32_t access_req;
        struct cifs_sid sid; /* ie UUID of user or group who gets these perms */
-};
+} __attribute__((packed));
 
 #endif /* CIFSACL_H */