selftest: make check password script more portable

We should not rely on Linux specific sed options.

grep -q also works on FreeBSD (tested on FreeBSD 12).

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

diff --git a/selftest/checkpassword_arg1.sh b/selftest/checkpassword_arg1.sh
new file mode 100755 (executable)
index 0000000..9cb28ef
--- /dev/null
+++ b/selftest/checkpassword_arg1.sh
@@ -0,0 +1,15 @@
+#!/bin/sh
+#
+
+set -e
+set -u
+
+INVALIDPW="$1"
+NEWPW=`cat -`
+
+echo -n "${NEWPW}" | grep -q "^${INVALIDPW}\$" && {
+       echo "Found invalid password" >&1
+       exit 1
+}
+
+exit 0

diff --git a/selftest/target/Samba4.pm b/selftest/target/Samba4.pm
index 33c66848c562ba299c9479ac1c2bf64951b1b906..d8e066f6f4472d14599388ebef903c2c0bb27297 100755 (executable)
--- a/selftest/target/Samba4.pm
+++ b/selftest/target/Samba4.pm
@@ -2173,7 +2173,7 @@ sub provision_chgdcpass($$)
        # (and also removes the default AD complexity checks)
        my $unacceptable_password = "widk3Dsle32jxdBdskldsk55klASKQ";
        my $extra_smb_conf = "
-       check password script = sed -e '/$unacceptable_password/{;q1}; /$unacceptable_password/!{q0}'
+       check password script = $self->{srcdir}/selftest/checkpassword_arg1.sh ${unacceptable_password}
        allow dcerpc auth level connect:lsarpc = yes
        dcesrv:max auth states = 8
 ";