selftest: fix flapping samba-tool drs showrepl test
authorRob van der Linde <rob@catalyst.net.nz>
Thu, 23 Feb 2023 03:56:30 +0000 (16:56 +1300)
committerAndrew Bartlett <abartlet@samba.org>
Thu, 23 Feb 2023 22:32:32 +0000 (22:32 +0000)
Test should have been using "schema_pair_dc", it was picking this up from the variable env in the loop above it.

However, it was hardcoded to use promoted_dc.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15316

Signed-off-by: Rob van der Linde <rob@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Joseph Sutton <josephsutton@catalyst.net.nz>
source4/selftest/tests.py

index 936cb76044b79433b2e795153aa4b70c0140bc36..08b29a85f6905aae390e4341c8028774852e745a 100755 (executable)
@@ -1554,7 +1554,8 @@ planoldpythontestsuite(env, "getnc_schema",
 # not the set of environments connected with ad_dc.
 
 # This will show the replication state of ad_dc
-planoldpythontestsuite("promoted_dc:local", "samba_tool_drs_showrepl",
+env = "schema_pair_dc"
+planoldpythontestsuite("%s:local" % env, "samba_tool_drs_showrepl",
                        extra_path=[os.path.join(samba4srcdir, 'torture/drs/python')],
                        name="samba4.drs.samba_tool_drs_showrepl.python(%s)" % env,
                        environ={'DC1': '$DC_SERVER', 'DC2': '$SERVER'},