git.samba.org
/
samba.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
092e112
)
lib:krb_wrap: Add missing error check in smb_krb5_salt_principal_str()
author
Andreas Schneider
<asn@samba.org>
Tue, 14 Dec 2021 15:12:43 +0000
(16:12 +0100)
committer
Jeremy Allison
<jra@samba.org>
Wed, 15 Dec 2021 19:32:30 +0000
(19:32 +0000)
Found by covscan.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
lib/krb5_wrap/krb5_samba.c
patch
|
blob
|
history
diff --git
a/lib/krb5_wrap/krb5_samba.c
b/lib/krb5_wrap/krb5_samba.c
index fff5b4e2a22fcd7ff57058fa615219134bf72ad7..61d651b4d5fed236a1734e3872ecec2c05244b4f 100644
(file)
--- a/
lib/krb5_wrap/krb5_samba.c
+++ b/
lib/krb5_wrap/krb5_samba.c
@@
-680,6
+680,11
@@
int smb_krb5_salt_principal_str(const char *realm,
userPrincipalName,
uac_flags,
&salt_principal);
+ if (krb5_ret != 0) {
+ DBG_ERR("unable to create salt principal:%s\n",
+ error_message(krb5_ret));
+ return krb5_ret;
+ }
krb5_ret = krb5_unparse_name(krb5_ctx, salt_principal,
&salt_principal_malloc);