s3:libnet: Fix dereference of NULL win7
authorPavel Filipenský <pfilipen@redhat.com>
Mon, 10 Jan 2022 12:24:22 +0000 (13:24 +0100)
committerJeremy Allison <jra@samba.org>
Mon, 10 Jan 2022 23:31:33 +0000 (23:31 +0000)
Found by covscan.

Pair-Programmed-With: Andreas Schneider <asn@samba.org>

Signed-off-by: Pavel Filipenský <pfilipen@redhat.com>
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
source3/libnet/libnet_join_offline.c

index 33380207209e319cf2b90db32b8b4558e7afb962..d1317ddfbeaec84379558b343e6b2b3c9ec5a273 100644 (file)
@@ -175,6 +175,9 @@ static WERROR libnet_odj_compose_OP_PACKAGE_PART(TALLOC_CTX *mem_ctx,
 
        switch (level) {
                case 1: /* ODJ_GUID_JOIN_PROVIDER */
+                       if (win7 == NULL) {
+                               return WERR_INVALID_PARAMETER;
+                       }
                        p->Part->win7blob = *win7;
                        break;
                case 2: /* ODJ_GUID_JOIN_PROVIDER2 */