python: Remove unused parameter ‘message’
authorJoseph Sutton <josephsutton@catalyst.net.nz>
Thu, 23 Nov 2023 07:48:56 +0000 (20:48 +1300)
committerAndrew Bartlett <abartlet@samba.org>
Thu, 14 Dec 2023 03:31:37 +0000 (03:31 +0000)
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
python/samba/tests/upgradeprovisionneeddc.py
python/samba/upgradehelpers.py
source4/scripting/bin/samba_upgradeprovision

index 432ca2ef55e8007e43711760e606f4d17ef89945..02860c34a53e2378b088dfd47e58b61fcda8d698 100644 (file)
@@ -139,7 +139,7 @@ class UpgradeProvisionWithLdbTestCase(TestCaseInTempDir):
                             self.names.policyid)
         shutil.rmtree(dir)
         self.assertFalse(os.path.isdir(dir))
-        update_gpo(self.paths, self.ldbs.sam, self.names, self.lp, dummymessage)
+        update_gpo(self.paths, self.ldbs.sam, self.names, self.lp)
         self.assertTrue(os.path.isdir(dir))
 
     def test_update_gpo_acl(self):
@@ -150,7 +150,7 @@ class UpgradeProvisionWithLdbTestCase(TestCaseInTempDir):
         os.mkdir(os.path.join(path, self.names.dnsdomain))
         os.mkdir(os.path.join(os.path.join(path, self.names.dnsdomain),
                               "Policies"))
-        update_gpo(self.paths, self.ldbs.sam, self.names, self.lp, dummymessage)
+        update_gpo(self.paths, self.ldbs.sam, self.names, self.lp)
         shutil.rmtree(path)
         self.paths.sysvol = save
 
index f1250feef0363a3ec18cb6ec793e939f2bd8b87c..e541540a0cc505278dc0d5c840eac5e32e2ecd89 100644 (file)
@@ -451,7 +451,7 @@ def updateOEMInfo(samdb, rootdn):
         samdb.modify(delta)
 
 
-def update_gpo(paths, samdb, names, lp, message):
+def update_gpo(paths, samdb, names, lp):
     """Create missing GPO file object if needed
     """
     dir = getpolicypath(paths.sysvol, names.dnsdomain, names.policyid)
index 018bfb91c158f862560a6641ee0457a734851790..f82091d2bf8e84583e66e290e4eead5c21ef8c79 100755 (executable)
@@ -1819,7 +1819,7 @@ if __name__ == '__main__':
 
         if opts.full:
             try:
-                update_gpo(paths, ldbs.sam, names, lp, message)
+                update_gpo(paths, ldbs.sam, names, lp)
             except ProvisioningError as e:
                 message(ERROR, "The policy for domain controller is missing. "
                             "You should restart upgradeprovision with --full")