good security patch from Timothy.Sell@unisys.com

we could generate short passwords!
samba-patches 880

diff --git a/source/lib/genrand.c b/source/lib/genrand.c
index ee8bc0b1d5abc59a11e75596cdc39872d3a0c874..fe756169a669735b58b0dfa81ac32bf43a4f5293 100644 (file)
--- a/source/lib/genrand.c
+++ b/source/lib/genrand.c
@@ -259,7 +259,7 @@ char *generate_random_str(size_t len)
                len = sizeof(retstr) -1;
        generate_random_buffer( retstr, len, False);
        for (i = 0; i < len; i++)
-               retstr[i] = c_list[ retstr[i] % sizeof(c_list) ];
+               retstr[i] = c_list[ retstr[i] % (sizeof(c_list)-1) ];
 
        retstr[i] = '\0';