auth4: add TODO comment on the auth_sam_trigger_repl_secret msDS-NeverRevealGroup...
authorStefan Metzmacher <metze@samba.org>
Thu, 23 Mar 2017 08:37:22 +0000 (09:37 +0100)
committerStefan Metzmacher <metze@samba.org>
Fri, 24 Mar 2017 10:57:08 +0000 (11:57 +0100)
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
source4/auth/ntlm/auth_sam.c

index 90eabcaf506968c171c0e3dd2e24d81a5c02e3ba..d3f9019612592782fd718bb5da33711d84c5d705 100644 (file)
@@ -237,6 +237,11 @@ static NTSTATUS authsam_password_check_and_record(struct auth4_context *auth_con
                         * mechanism. We also send a message to our
                         * drepl server to tell it to try and
                         * replicate the secrets for this account.
+                        *
+                        * TODO: Should we only trigger this is detected
+                        * there's a chance that the password might be
+                        * replicated, we should be able to detect this
+                        * based on msDS-NeverRevealGroup.
                         */
                        auth_sam_trigger_repl_secret(auth_context, msg->dn);
                        TALLOC_FREE(tmp_ctx);