smbstatus: Fix an uninitialized variable
authorVolker Lendecke <vl@samba.org>
Sun, 29 Jun 2014 08:56:03 +0000 (08:56 +0000)
committerKarolin Seeger <kseeger@samba.org>
Fri, 11 Jul 2014 07:07:15 +0000 (09:07 +0200)
We only print valid share mode entries, stale ones don't count. In
traverse, let the callback decide about staleness.

https://bugzilla.samba.org/show_bug.cgi?id=10680

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 9f2e90754bcb7bf5f7159d07f0bc5fe754e71bf5)

source3/locking/share_mode_lock.c

index 6782f592ff87259778a24915f87f862ac8675c4d..d9076dbe430f5015bb8ae0d8e1e4943cf6f82274 100644 (file)
@@ -487,6 +487,7 @@ static int traverse_fn(struct db_record *rec, void *_state)
                return 0;
        }
        for (i=0; i<d->num_share_modes; i++) {
                return 0;
        }
        for (i=0; i<d->num_share_modes; i++) {
+               d->share_modes[i].stale = false; /* [skip] in idl */
                state->fn(&d->share_modes[i],
                          d->servicepath, d->base_name,
                          state->private_data);
                state->fn(&d->share_modes[i],
                          d->servicepath, d->base_name,
                          state->private_data);