s4-ldb_ldif: Don't check for LDB_FLG_SHOW_BINARY in ldb_should_b64_encode
authorKamen Mazdrashki <kamenim@samba.org>
Mon, 17 Jan 2011 22:49:17 +0000 (00:49 +0200)
committerKamen Mazdrashki <kamenim@samba.org>
Mon, 17 Jan 2011 22:57:05 +0000 (00:57 +0200)
commitfb0df534f46ccee8d541d5512abbcc9cd8247e53
tree249bf3716d825d89799c223506196d8ebccfd8cd
parent622ef6aed82a2f2f7748c2a88535486af77487de
s4-ldb_ldif: Don't check for LDB_FLG_SHOW_BINARY in ldb_should_b64_encode

LDB_FLG_SHOW_BINARY is data representation flag and should
not modify behavior of data checking functions.

This lead to a bug in lib/ldb/ldb_tdb/ldb_index.c as ltdb_index_key()
function relies on ldb_should_b64_encode function to determine
how to process index keys.

Found using following test search:
bin/ldbsearch -H st/dc/private/sam.ldb -b "CN=Deleted Objects,DC=samba,DC=example,DC=com" \
 "(objectGUID=97b52eac-6d89-434d-b935-1e5f2e086ffc)" replPropertyMetaData --show-deleted --show-binary
source4/lib/ldb/common/ldb_ldif.c