git.samba.org / jlayton / cifs-utils.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: ec983ad) | patch
get/setcifsacl: fix bad bit-shifts
authorJeff Layton <jlayton@samba.org>
Wed, 9 Oct 2013 01:07:24 +0000 (21:07 -0400)
committerJeff Layton <jlayton@samba.org>
Wed, 9 Oct 2013 01:14:08 +0000 (21:14 -0400)
commit99d2a5a4517216a63cfdeef3ee30656938b3a98e
tree1641432f5b4512c18d45cb128f1e1bb220db48fdtree
parentec983ad90408b689408c2c89179bf8f7b35665a6commit | diff
get/setcifsacl: fix bad bit-shifts

A Coverity scan turned up this warning:

1. cifs-utils-6.2/setcifsacl.c:578:result_independent_of_operands – "(x & 0xff0000000000ULL) >> 48" is 0 regardless of the values of its operands. This occurs as the operand of assignment.

...which is entirely true. That shift should be 40 bits, not 48. Also
fix a similar bug in getcifsacl.c.

Signed-off-by: Jeff Layton <jlayton@samba.org>
getcifsacl.c diff | blob | history
setcifsacl.c diff | blob | history
Jeff Layton's cifs-utils development repo