r6127: Eliminated all compiler warnings pertaining to mismatched "qualifiers". The
authorDerrell Lipman <derrell@samba.org>
Wed, 30 Mar 2005 04:40:24 +0000 (04:40 +0000)
committerGerald (Jerry) Carter <jerry@samba.org>
Wed, 10 Oct 2007 15:56:24 +0000 (10:56 -0500)
commit5b19ede88ed80318e392f8017f4573fbb2ecbe0f
treecef2400387129db212b0007bb30c797a4123a40f
parente1df648ea13651e1df3d209937034b351a7f1c2b
r6127: Eliminated all compiler warnings pertaining to mismatched "qualifiers".  The
whole of samba comiles warning-free with the default compiler flags.

Temporarily defined -Wall to locate other potential problems.  Found an
unused static function (#ifdefed out rather than deleted, in case it's
needed for something in progress).

There are also a number of uses of undeclared functions, mostly krb5_*.
Files with these problems need to have appropriate header files included,
but they are not fixed in this update.

oplock_linux.c.c has undefined functions capget() and capset(), which need
to have "#undef _POSIX_SOURCE" specified before including <sys/capability.h>,
but that could potentially have other side effects, so that remains uncorrected
as well.

The flag -Wall should be added permanently to CFLAGS, and all warnings then
generated should be eliminated.
14 files changed:
source/include/smb_macros.h
source/lib/smbldap.c
source/libads/kerberos.c
source/libsmb/spnego.c
source/nsswitch/winbindd_acct.c
source/nsswitch/winbindd_nss.h
source/nsswitch/winbindd_rpc.c
source/nsswitch/winbindd_util.c
source/rpc_server/srv_svcctl_nt.c
source/tdb/tdb.c
source/tdb/tdbutil.c
source/utils/net_ads.c
source/utils/net_lookup.c
source/utils/smbcontrol.c