r13840: Mark some functions as public.
[samba.git] / source4 / librpc / ndr / ndr_basic.c
index a3c4bc0aec6aab9ae0fa77f03cdb9f39d9d21164..000a0c34980af11b9032b1d7a8d4527946336830 100644 (file)
 */
 
 #include "includes.h"
+#include "system/network.h"
+
+#define NDR_SVAL(ndr, ofs) (NDR_BE(ndr)?RSVAL(ndr->data,ofs):SVAL(ndr->data,ofs))
+#define NDR_IVAL(ndr, ofs) (NDR_BE(ndr)?RIVAL(ndr->data,ofs):IVAL(ndr->data,ofs))
+#define NDR_IVALS(ndr, ofs) (NDR_BE(ndr)?RIVALS(ndr->data,ofs):IVALS(ndr->data,ofs))
+#define NDR_SSVAL(ndr, ofs, v) do { if (NDR_BE(ndr))  { RSSVAL(ndr->data,ofs,v); } else SSVAL(ndr->data,ofs,v); } while (0)
+#define NDR_SIVAL(ndr, ofs, v) do { if (NDR_BE(ndr))  { RSIVAL(ndr->data,ofs,v); } else SIVAL(ndr->data,ofs,v); } while (0)
+#define NDR_SIVALS(ndr, ofs, v) do { if (NDR_BE(ndr))  { RSIVALS(ndr->data,ofs,v); } else SIVALS(ndr->data,ofs,v); } while (0)
+
+
+/*
+  check for data leaks from the server by looking for non-zero pad bytes
+  these could also indicate that real structure elements have been
+  mistaken for padding in the IDL
+*/
+_PUBLIC_ void ndr_check_padding(struct ndr_pull *ndr, size_t n)
+{
+       size_t ofs2 = (ndr->offset + (n-1)) & ~(n-1);
+       int i;
+       for (i=ndr->offset;i<ofs2;i++) {
+               if (ndr->data[i] != 0) {
+                       break;
+               }
+       }
+       if (i<ofs2) {
+               DEBUG(0,("WARNING: Non-zero padding to %d: ", (int)n));
+               for (i=ndr->offset;i<ofs2;i++) {
+                       DEBUG(0,("%02x ", ndr->data[i]));
+               }
+               DEBUG(0,("\n"));
+       }
+
+}
+
+/*
+  parse a int8_t
+*/
+_PUBLIC_ NTSTATUS ndr_pull_int8(struct ndr_pull *ndr, int ndr_flags, int8_t *v)
+{
+       NDR_PULL_NEED_BYTES(ndr, 1);
+       *v = (int8_t)CVAL(ndr->data, ndr->offset);
+       ndr->offset += 1;
+       return NT_STATUS_OK;
+}
 
 /*
-  parse a uint8
+  parse a uint8_t
 */
-NTSTATUS ndr_pull_uint8(struct ndr_pull *ndr, uint8 *v)
+_PUBLIC_ NTSTATUS ndr_pull_uint8(struct ndr_pull *ndr, int ndr_flags, uint8_t *v)
 {
        NDR_PULL_NEED_BYTES(ndr, 1);
        *v = CVAL(ndr->data, ndr->offset);
@@ -33,52 +77,142 @@ NTSTATUS ndr_pull_uint8(struct ndr_pull *ndr, uint8 *v)
        return NT_STATUS_OK;
 }
 
+/*
+  parse a int16_t
+*/
+_PUBLIC_ NTSTATUS ndr_pull_int16(struct ndr_pull *ndr, int ndr_flags, int16_t *v)
+{
+       NDR_PULL_ALIGN(ndr, 2);
+       NDR_PULL_NEED_BYTES(ndr, 2);
+       *v = (uint16_t)NDR_SVAL(ndr, ndr->offset);
+       ndr->offset += 2;
+       return NT_STATUS_OK;
+}
 
 /*
-  parse a uint16
+  parse a uint16_t
 */
-NTSTATUS ndr_pull_uint16(struct ndr_pull *ndr, uint16 *v)
+_PUBLIC_ NTSTATUS ndr_pull_uint16(struct ndr_pull *ndr, int ndr_flags, uint16_t *v)
 {
        NDR_PULL_ALIGN(ndr, 2);
        NDR_PULL_NEED_BYTES(ndr, 2);
-       *v = SVAL(ndr->data, ndr->offset);
+       *v = NDR_SVAL(ndr, ndr->offset);
        ndr->offset += 2;
        return NT_STATUS_OK;
 }
 
+/*
+  parse a int32_t
+*/
+_PUBLIC_ NTSTATUS ndr_pull_int32(struct ndr_pull *ndr, int ndr_flags, int32_t *v)
+{
+       NDR_PULL_ALIGN(ndr, 4);
+       NDR_PULL_NEED_BYTES(ndr, 4);
+       *v = NDR_IVALS(ndr, ndr->offset);
+       ndr->offset += 4;
+       return NT_STATUS_OK;
+}
 
 /*
-  parse a uint32
+  parse a uint32_t
 */
-NTSTATUS ndr_pull_uint32(struct ndr_pull *ndr, uint32 *v)
+_PUBLIC_ NTSTATUS ndr_pull_uint32(struct ndr_pull *ndr, int ndr_flags, uint32_t *v)
 {
        NDR_PULL_ALIGN(ndr, 4);
        NDR_PULL_NEED_BYTES(ndr, 4);
-       *v = IVAL(ndr->data, ndr->offset);
+       *v = NDR_IVAL(ndr, ndr->offset);
        ndr->offset += 4;
        return NT_STATUS_OK;
 }
 
 /*
-  parse a HYPER_T
+  parse a pointer referent identifier
 */
-NTSTATUS ndr_pull_HYPER_T(struct ndr_pull *ndr, HYPER_T *v)
+_PUBLIC_ NTSTATUS ndr_pull_generic_ptr(struct ndr_pull *ndr, uint32_t *v)
 {
-       NDR_PULL_ALIGN(ndr, 8);
+       NTSTATUS status;
+       status = ndr_pull_uint32(ndr, NDR_SCALARS, v);
+       if (NT_STATUS_IS_OK(status) && *v != 0) {
+               ndr->ptr_count++;
+       }
+       return status;
+}
+
+/*
+  parse a ref pointer referent identifier
+*/
+_PUBLIC_ NTSTATUS ndr_pull_ref_ptr(struct ndr_pull *ndr, uint32_t *v)
+{
+       NDR_CHECK(ndr_pull_uint32(ndr, NDR_SCALARS, v));
+       /* ref pointers always point to data */
+       *v = 1;
+       return NT_STATUS_OK;
+}
+
+/*
+  parse a udlong
+*/
+_PUBLIC_ NTSTATUS ndr_pull_udlong(struct ndr_pull *ndr, int ndr_flags, uint64_t *v)
+{
+       NDR_PULL_ALIGN(ndr, 4);
        NDR_PULL_NEED_BYTES(ndr, 8);
-       v->low = IVAL(ndr->data, ndr->offset);
-       v->high = IVAL(ndr->data, ndr->offset+4);
+       *v = NDR_IVAL(ndr, ndr->offset);
+       *v |= (uint64_t)(NDR_IVAL(ndr, ndr->offset+4)) << 32;
        ndr->offset += 8;
        return NT_STATUS_OK;
 }
 
+/*
+  parse a udlongr
+*/
+_PUBLIC_ NTSTATUS ndr_pull_udlongr(struct ndr_pull *ndr, int ndr_flags, uint64_t *v)
+{
+       NDR_PULL_ALIGN(ndr, 4);
+       NDR_PULL_NEED_BYTES(ndr, 8);
+       *v = ((uint64_t)NDR_IVAL(ndr, ndr->offset)) << 32;
+       *v |= NDR_IVAL(ndr, ndr->offset+4);
+       ndr->offset += 8;
+       return NT_STATUS_OK;
+}
+
+/*
+  parse a dlong
+*/
+_PUBLIC_ NTSTATUS ndr_pull_dlong(struct ndr_pull *ndr, int ndr_flags, int64_t *v)
+{
+       return ndr_pull_udlong(ndr, ndr_flags, (uint64_t *)v);
+}
+
+/*
+  parse a hyper
+*/
+_PUBLIC_ NTSTATUS ndr_pull_hyper(struct ndr_pull *ndr, int ndr_flags, uint64_t *v)
+{
+       NDR_PULL_ALIGN(ndr, 8);
+       return ndr_pull_udlong(ndr, ndr_flags, v);
+}
+
+/*
+  parse a pointer
+*/
+_PUBLIC_ NTSTATUS ndr_pull_pointer(struct ndr_pull *ndr, int ndr_flags, void* *v)
+{
+       intptr_t h;
+       NDR_PULL_ALIGN(ndr, sizeof(h));
+       NDR_PULL_NEED_BYTES(ndr, sizeof(h));
+       memcpy(&h, ndr->data+ndr->offset, sizeof(h));
+       ndr->offset += sizeof(h);
+       *v = (void *)h;
+       return NT_STATUS_OK;    
+}
+
 /*
   pull a NTSTATUS
 */
-NTSTATUS ndr_pull_NTSTATUS(struct ndr_pull *ndr, NTSTATUS *status)
+_PUBLIC_ NTSTATUS ndr_pull_NTSTATUS(struct ndr_pull *ndr, int ndr_flags, NTSTATUS *status)
 {
-       uint32 v;
-       NDR_CHECK(ndr_pull_uint32(ndr, &v));
+       uint32_t v;
+       NDR_CHECK(ndr_pull_uint32(ndr, NDR_SCALARS, &v));
        *status = NT_STATUS(v);
        return NT_STATUS_OK;
 }
@@ -86,23 +220,23 @@ NTSTATUS ndr_pull_NTSTATUS(struct ndr_pull *ndr, NTSTATUS *status)
 /*
   push a NTSTATUS
 */
-NTSTATUS ndr_push_NTSTATUS(struct ndr_push *ndr, NTSTATUS status)
+_PUBLIC_ NTSTATUS ndr_push_NTSTATUS(struct ndr_push *ndr, int ndr_flags, NTSTATUS status)
 {
-       return ndr_push_uint32(ndr, NT_STATUS_V(status));
+       return ndr_push_uint32(ndr, ndr_flags, NT_STATUS_V(status));
 }
 
-void ndr_print_NTSTATUS(struct ndr_print *ndr, const char *name, NTSTATUS *r)
+_PUBLIC_ void ndr_print_NTSTATUS(struct ndr_print *ndr, const char *name, NTSTATUS r)
 {
-       ndr->print(ndr, "%-25s: %s", name, nt_errstr(*r));
+       ndr->print(ndr, "%-25s: %s", name, nt_errstr(r));
 }
 
 /*
   pull a WERROR
 */
-NTSTATUS ndr_pull_WERROR(struct ndr_pull *ndr, WERROR *status)
+_PUBLIC_ NTSTATUS ndr_pull_WERROR(struct ndr_pull *ndr, int ndr_flags, WERROR *status)
 {
-       uint32 v;
-       NDR_CHECK(ndr_pull_uint32(ndr, &v));
+       uint32_t v;
+       NDR_CHECK(ndr_pull_uint32(ndr, NDR_SCALARS, &v));
        *status = W_ERROR(v);
        return NT_STATUS_OK;
 }
@@ -110,20 +244,20 @@ NTSTATUS ndr_pull_WERROR(struct ndr_pull *ndr, WERROR *status)
 /*
   push a WERROR
 */
-NTSTATUS ndr_push_WERROR(struct ndr_push *ndr, WERROR status)
+_PUBLIC_ NTSTATUS ndr_push_WERROR(struct ndr_push *ndr, int ndr_flags, WERROR status)
 {
-       return ndr_push_uint32(ndr, W_ERROR_V(status));
+       return ndr_push_uint32(ndr, NDR_SCALARS, W_ERROR_V(status));
 }
 
-void ndr_print_WERROR(struct ndr_print *ndr, const char *name, WERROR *r)
+_PUBLIC_ void ndr_print_WERROR(struct ndr_print *ndr, const char *name, WERROR r)
 {
-       ndr->print(ndr, "%-25s: %s", name, win_errstr(*r));
+       ndr->print(ndr, "%-25s: %s", name, win_errstr(r));
 }
 
 /*
   parse a set of bytes
 */
-NTSTATUS ndr_pull_bytes(struct ndr_pull *ndr, char *data, uint32 n)
+_PUBLIC_ NTSTATUS ndr_pull_bytes(struct ndr_pull *ndr, uint8_t *data, uint32_t n)
 {
        NDR_PULL_NEED_BYTES(ndr, n);
        memcpy(data, ndr->data + ndr->offset, n);
@@ -134,7 +268,7 @@ NTSTATUS ndr_pull_bytes(struct ndr_pull *ndr, char *data, uint32 n)
 /*
   pull an array of uint8
 */
-NTSTATUS ndr_pull_array_uint8(struct ndr_pull *ndr, int ndr_flags, char *data, uint32 n)
+_PUBLIC_ NTSTATUS ndr_pull_array_uint8(struct ndr_pull *ndr, int ndr_flags, uint8_t *data, uint32_t n)
 {
        if (!(ndr_flags & NDR_SCALARS)) {
                return NT_STATUS_OK;
@@ -142,104 +276,139 @@ NTSTATUS ndr_pull_array_uint8(struct ndr_pull *ndr, int ndr_flags, char *data, u
        return ndr_pull_bytes(ndr, data, n);
 }
 
-
 /*
-  pull an array of uint16
+  push a int8_t
 */
-NTSTATUS ndr_pull_array_uint16(struct ndr_pull *ndr, int ndr_flags, uint16 *data, uint32 n)
+_PUBLIC_ NTSTATUS ndr_push_int8(struct ndr_push *ndr, int ndr_flags, int8_t v)
 {
-       uint32 i;
-       if (!(ndr_flags & NDR_SCALARS)) {
-               return NT_STATUS_OK;
-       }
-       for (i=0;i<n;i++) {
-               NDR_CHECK(ndr_pull_uint16(ndr, &data[i]));
-       }
+       NDR_PUSH_NEED_BYTES(ndr, 1);
+       SCVAL(ndr->data, ndr->offset, (uint8_t)v);
+       ndr->offset += 1;
        return NT_STATUS_OK;
 }
 
 /*
-  pull a const array of uint32
+  push a uint8_t
 */
-NTSTATUS ndr_pull_array_uint32(struct ndr_pull *ndr, int ndr_flags, uint32 *data, uint32 n)
+_PUBLIC_ NTSTATUS ndr_push_uint8(struct ndr_push *ndr, int ndr_flags, uint8_t v)
 {
-       uint32 i;
-       if (!(ndr_flags & NDR_SCALARS)) {
-               return NT_STATUS_OK;
-       }
-       for (i=0;i<n;i++) {
-               NDR_CHECK(ndr_pull_uint32(ndr, &data[i]));
-       }
+       NDR_PUSH_NEED_BYTES(ndr, 1);
+       SCVAL(ndr->data, ndr->offset, v);
+       ndr->offset += 1;
        return NT_STATUS_OK;
 }
 
 /*
-  parse a GUID
+  push a int16_t
 */
-NTSTATUS ndr_pull_GUID(struct ndr_pull *ndr, int ndr_flags, GUID *guid)
+_PUBLIC_ NTSTATUS ndr_push_int16(struct ndr_push *ndr, int ndr_flags, int16_t v)
 {
-       if (ndr_flags & NDR_SCALARS) {
-               return ndr_pull_bytes(ndr, guid->info, GUID_SIZE);
-       }
+       NDR_PUSH_ALIGN(ndr, 2);
+       NDR_PUSH_NEED_BYTES(ndr, 2);
+       NDR_SSVAL(ndr, ndr->offset, (uint16_t)v);
+       ndr->offset += 2;
        return NT_STATUS_OK;
 }
 
-
 /*
-  push a uint8
+  push a uint16_t
 */
-NTSTATUS ndr_push_uint8(struct ndr_push *ndr, uint8 v)
+_PUBLIC_ NTSTATUS ndr_push_uint16(struct ndr_push *ndr, int ndr_flags, uint16_t v)
 {
-       NDR_PUSH_NEED_BYTES(ndr, 1);
-       SCVAL(ndr->data, ndr->offset, v);
-       ndr->offset += 1;
+       NDR_PUSH_ALIGN(ndr, 2);
+       NDR_PUSH_NEED_BYTES(ndr, 2);
+       NDR_SSVAL(ndr, ndr->offset, v);
+       ndr->offset += 2;
        return NT_STATUS_OK;
 }
 
 /*
-  push a uint16
+  push a int32_t
 */
-NTSTATUS ndr_push_uint16(struct ndr_push *ndr, uint16 v)
+_PUBLIC_ NTSTATUS ndr_push_int32(struct ndr_push *ndr, int ndr_flags, int32_t v)
 {
-       NDR_PUSH_ALIGN(ndr, 2);
-       NDR_PUSH_NEED_BYTES(ndr, 2);
-       SSVAL(ndr->data, ndr->offset, v);
-       ndr->offset += 2;
+       NDR_PUSH_ALIGN(ndr, 4);
+       NDR_PUSH_NEED_BYTES(ndr, 4);
+       NDR_SIVALS(ndr, ndr->offset, v);
+       ndr->offset += 4;
        return NT_STATUS_OK;
 }
 
 /*
-  push a uint32
+  push a uint32_t
 */
-NTSTATUS ndr_push_uint32(struct ndr_push *ndr, uint32 v)
+_PUBLIC_ NTSTATUS ndr_push_uint32(struct ndr_push *ndr, int ndr_flags, uint32_t v)
 {
        NDR_PUSH_ALIGN(ndr, 4);
        NDR_PUSH_NEED_BYTES(ndr, 4);
-       SIVAL(ndr->data, ndr->offset, v);
+       NDR_SIVAL(ndr, ndr->offset, v);
        ndr->offset += 4;
        return NT_STATUS_OK;
 }
 
 /*
-  push a HYPER_T
+  push a udlong
 */
-NTSTATUS ndr_push_HYPER_T(struct ndr_push *ndr, HYPER_T v)
+_PUBLIC_ NTSTATUS ndr_push_udlong(struct ndr_push *ndr, int ndr_flags, uint64_t v)
 {
-       NDR_PUSH_ALIGN(ndr, 8);
+       NDR_PUSH_ALIGN(ndr, 4);
+       NDR_PUSH_NEED_BYTES(ndr, 8);
+       NDR_SIVAL(ndr, ndr->offset, (v & 0xFFFFFFFF));
+       NDR_SIVAL(ndr, ndr->offset+4, (v>>32));
+       ndr->offset += 8;
+       return NT_STATUS_OK;
+}
+
+/*
+  push a udlongr
+*/
+_PUBLIC_ NTSTATUS ndr_push_udlongr(struct ndr_push *ndr, int ndr_flags, uint64_t v)
+{
+       NDR_PUSH_ALIGN(ndr, 4);
        NDR_PUSH_NEED_BYTES(ndr, 8);
-       SIVAL(ndr->data, ndr->offset, v.low);
-       SIVAL(ndr->data, ndr->offset+4, v.high);
+       NDR_SIVAL(ndr, ndr->offset, (v>>32));
+       NDR_SIVAL(ndr, ndr->offset+4, (v & 0xFFFFFFFF));
        ndr->offset += 8;
        return NT_STATUS_OK;
 }
 
-NTSTATUS ndr_push_align(struct ndr_push *ndr, size_t size)
+/*
+  push a dlong
+*/
+_PUBLIC_ NTSTATUS ndr_push_dlong(struct ndr_push *ndr, int ndr_flags, int64_t v)
+{
+       return ndr_push_udlong(ndr, NDR_SCALARS, (uint64_t)v);
+}
+
+/*
+  push a hyper
+*/
+_PUBLIC_ NTSTATUS ndr_push_hyper(struct ndr_push *ndr, int ndr_flags, uint64_t v)
+{
+       NDR_PUSH_ALIGN(ndr, 8);
+       return ndr_push_udlong(ndr, NDR_SCALARS, v);
+}
+
+/*
+  push a pointer
+*/
+_PUBLIC_ NTSTATUS ndr_push_pointer(struct ndr_push *ndr, int ndr_flags, void* v)
+{
+       intptr_t h = (intptr_t)v;
+       NDR_PUSH_ALIGN(ndr, sizeof(h));
+       NDR_PUSH_NEED_BYTES(ndr, sizeof(h));
+       memcpy(ndr->data+ndr->offset, &h, sizeof(h));
+       ndr->offset += sizeof(h);
+       return NT_STATUS_OK;    
+}
+
+_PUBLIC_ NTSTATUS ndr_push_align(struct ndr_push *ndr, size_t size)
 {
        NDR_PUSH_ALIGN(ndr, size);
        return NT_STATUS_OK;
 }
 
-NTSTATUS ndr_pull_align(struct ndr_pull *ndr, size_t size)
+_PUBLIC_ NTSTATUS ndr_pull_align(struct ndr_pull *ndr, size_t size)
 {
        NDR_PULL_ALIGN(ndr, size);
        return NT_STATUS_OK;
@@ -248,7 +417,7 @@ NTSTATUS ndr_pull_align(struct ndr_pull *ndr, size_t size)
 /*
   push some bytes
 */
-NTSTATUS ndr_push_bytes(struct ndr_push *ndr, const char *data, uint32 n)
+_PUBLIC_ NTSTATUS ndr_push_bytes(struct ndr_push *ndr, const uint8_t *data, uint32_t n)
 {
        NDR_PUSH_NEED_BYTES(ndr, n);
        memcpy(ndr->data + ndr->offset, data, n);
@@ -257,35 +426,31 @@ NTSTATUS ndr_push_bytes(struct ndr_push *ndr, const char *data, uint32 n)
 }
 
 /*
-  push an array of uint8
+  push some zero bytes
 */
-NTSTATUS ndr_push_array_uint8(struct ndr_push *ndr, int ndr_flags, const char *data, uint32 n)
+_PUBLIC_ NTSTATUS ndr_push_zero(struct ndr_push *ndr, uint32_t n)
 {
-       if (!(ndr_flags & NDR_SCALARS)) {
-               return NT_STATUS_OK;
-       }
-       return ndr_push_bytes(ndr, data, n);
+       NDR_PUSH_NEED_BYTES(ndr, n);
+       memset(ndr->data + ndr->offset, 0, n);
+       ndr->offset += n;
+       return NT_STATUS_OK;
 }
 
 /*
-  push an array of uint32
+  push an array of uint8
 */
-NTSTATUS ndr_push_array_uint32(struct ndr_push *ndr, int ndr_flags, const uint32 *data, uint32 n)
+_PUBLIC_ NTSTATUS ndr_push_array_uint8(struct ndr_push *ndr, int ndr_flags, const uint8_t *data, uint32_t n)
 {
-       int i;
        if (!(ndr_flags & NDR_SCALARS)) {
                return NT_STATUS_OK;
        }
-       for (i=0;i<n;i++) {
-               NDR_CHECK(ndr_push_uint32(ndr, data[i]));
-       }
-       return NT_STATUS_OK;
+       return ndr_push_bytes(ndr, data, n);
 }
 
 /*
   save the current position
  */
-void ndr_push_save(struct ndr_push *ndr, struct ndr_push_save *save)
+_PUBLIC_ void ndr_push_save(struct ndr_push *ndr, struct ndr_push_save *save)
 {
        save->offset = ndr->offset;
 }
@@ -293,348 +458,252 @@ void ndr_push_save(struct ndr_push *ndr, struct ndr_push_save *save)
 /*
   restore the position
  */
-void ndr_push_restore(struct ndr_push *ndr, struct ndr_push_save *save)
+_PUBLIC_ void ndr_push_restore(struct ndr_push *ndr, struct ndr_push_save *save)
 {
        ndr->offset = save->offset;
 }
 
 /*
-  this is used when a packet has a 4 byte length field. We remember the start position
-  and come back to it later to fill in the size
+  push a unique non-zero value if a pointer is non-NULL, otherwise 0
 */
-NTSTATUS ndr_push_length4_start(struct ndr_push *ndr, struct ndr_push_save *save)
-{
-       NDR_PUSH_ALIGN(ndr, 4);
-       ndr_push_save(ndr, save);
-       return ndr_push_uint32(ndr, 0);
-}
-
-NTSTATUS ndr_push_length4_end(struct ndr_push *ndr, struct ndr_push_save *save)
+_PUBLIC_ NTSTATUS ndr_push_unique_ptr(struct ndr_push *ndr, const void *p)
 {
-       struct ndr_push_save save2;
-       ndr_push_save(ndr, &save2);
-       ndr_push_restore(ndr, save);
-       NDR_CHECK(ndr_push_uint32(ndr, save2.offset - ndr->offset));
-       ndr_push_restore(ndr, &save2);
-       return NT_STATUS_OK;
+       uint32_t ptr = 0;
+       if (p) {
+               ptr = ndr->ptr_count * 4;
+               ptr |= 0x00020000;
+               ndr->ptr_count++;
+       }
+       return ndr_push_uint32(ndr, NDR_SCALARS, ptr);
 }
 
 /*
-  push a 1 if a pointer is non-NULL, otherwise 0
+  push a 'simple' full non-zero value if a pointer is non-NULL, otherwise 0
 */
-NTSTATUS ndr_push_ptr(struct ndr_push *ndr, const void *p)
+_PUBLIC_ NTSTATUS ndr_push_sptr_ptr(struct ndr_push *ndr, const void *p)
 {
-       uint32 ptr = 0;
+       uint32_t ptr = 0;
        if (p) {
-               /* we do this to ensure that we generate unique ref ids,
-                  which means we can handle the case where a MS programmer
-                  forgot to mark a pointer as unique */
                ndr->ptr_count++;
                ptr = ndr->ptr_count;
        }
-       return ndr_push_uint32(ndr, ptr);
+       return ndr_push_uint32(ndr, NDR_SCALARS, ptr);
 }
 
-
 /*
-  pull a general string from the wire
+  push always a 0, if a pointer is NULL it's a fatal error
 */
-NTSTATUS ndr_pull_string(struct ndr_pull *ndr, int ndr_flags, const char **s)
+_PUBLIC_ NTSTATUS ndr_push_ref_ptr(struct ndr_push *ndr, const void *p)
 {
-       char *as=NULL;
-       uint32 len1, ofs, len2;
-       int ret;
-
-       if (!(ndr_flags & NDR_SCALARS)) {
-               return NT_STATUS_OK;
+       if (p == NULL) {
+               return NT_STATUS_INVALID_PARAMETER_MIX;
        }
+       return ndr_push_uint32(ndr, NDR_SCALARS, 0xAEF1AEF1);
+}
 
-       switch (ndr->flags & LIBNDR_STRING_FLAGS) {
-       case LIBNDR_FLAG_STR_LEN4|LIBNDR_FLAG_STR_SIZE4:
-       case LIBNDR_FLAG_STR_LEN4|LIBNDR_FLAG_STR_SIZE4|LIBNDR_FLAG_STR_NOTERM:
-               NDR_CHECK(ndr_pull_uint32(ndr, &len1));
-               NDR_CHECK(ndr_pull_uint32(ndr, &ofs));
-               NDR_CHECK(ndr_pull_uint32(ndr, &len2));
-               if (len2 > len1) {
-                       return ndr_pull_error(ndr, NDR_ERR_STRING, 
-                                             "Bad string lengths len1=%u ofs=%u len2=%u\n", 
-                                             len1, ofs, len2);
-               }
-               if (len2 == 0) {
-                       *s = talloc_strdup(ndr->mem_ctx, "");
-                       break;
-               }
-               NDR_PULL_NEED_BYTES(ndr, len2*2);
-               ret = convert_string_talloc(ndr->mem_ctx, CH_UCS2, CH_UNIX, 
-                                           ndr->data+ndr->offset, 
-                                           len2*2,
-                                           (const void **)&as);
-               if (ret == -1) {
-                       return ndr_pull_error(ndr, NDR_ERR_CHARCNV, 
-                                             "Bad character conversion");
-               }
-               NDR_CHECK(ndr_pull_advance(ndr, len2*2));
-               *s = as;
-               break;
-
-       case LIBNDR_FLAG_STR_SIZE4:
-               NDR_CHECK(ndr_pull_uint32(ndr, &len1));
-               NDR_PULL_NEED_BYTES(ndr, len1*2);
-               if (len1 == 0) {
-                       *s = talloc_strdup(ndr->mem_ctx, "");
-                       break;
-               }
-               ret = convert_string_talloc(ndr->mem_ctx, CH_UCS2, CH_UNIX, 
-                                           ndr->data+ndr->offset, 
-                                           len1*2,
-                                           (const void **)&as);
-               if (ret == -1) {
-                       return ndr_pull_error(ndr, NDR_ERR_CHARCNV, 
-                                             "Bad character conversion");
-               }
-               NDR_CHECK(ndr_pull_advance(ndr, len1*2));
-               *s = as;
-               break;
-
-       case LIBNDR_FLAG_STR_NULLTERM:
-               ret = convert_string_talloc(ndr->mem_ctx, CH_UCS2, CH_UNIX, 
-                                           ndr->data+ndr->offset, 
-                                           ndr->data_size - ndr->offset,
-                                           (const void **)s);
-               if (ret == -1) {
-                       return ndr_pull_error(ndr, NDR_ERR_CHARCNV, 
-                                             "Bad character conversion");
-               }
-               NDR_CHECK(ndr_pull_advance(ndr, ret));
-               break;
-
-       case LIBNDR_FLAG_STR_ASCII|LIBNDR_FLAG_STR_LEN4|LIBNDR_FLAG_STR_SIZE4:
-               NDR_CHECK(ndr_pull_uint32(ndr, &len1));
-               NDR_CHECK(ndr_pull_uint32(ndr, &ofs));
-               NDR_CHECK(ndr_pull_uint32(ndr, &len2));
-               if (len2 > len1) {
-                       return ndr_pull_error(ndr, NDR_ERR_STRING, 
-                                             "Bad ascii string lengths len1=%u ofs=%u len2=%u\n", 
-                                             len1, ofs, len2);
-               }
-               NDR_ALLOC_N(ndr, as, (len2+1));
-               NDR_CHECK(ndr_pull_bytes(ndr, as, len2));
-               as[len2] = 0;
-               (*s) = as;
-               break;
-
-       case LIBNDR_FLAG_STR_ASCII|LIBNDR_FLAG_STR_LEN4:
-               NDR_CHECK(ndr_pull_uint32(ndr, &ofs));
-               NDR_CHECK(ndr_pull_uint32(ndr, &len2));
-               NDR_ALLOC_N(ndr, as, (len2+1));
-               NDR_CHECK(ndr_pull_bytes(ndr, as, len2));
-               as[len2] = 0;
-               (*s) = as;
-               break;
-
-       default:
-               return ndr_pull_error(ndr, NDR_ERR_STRING, "Bad string flags 0x%x\n",
-                                     ndr->flags & LIBNDR_STRING_FLAGS);
-       }
 
+/*
+  push a NTTIME
+*/
+_PUBLIC_ NTSTATUS ndr_push_NTTIME(struct ndr_push *ndr, int ndr_flags, NTTIME t)
+{
+       NDR_CHECK(ndr_push_udlong(ndr, ndr_flags, t));
        return NT_STATUS_OK;
 }
 
+/*
+  pull a NTTIME
+*/
+_PUBLIC_ NTSTATUS ndr_pull_NTTIME(struct ndr_pull *ndr, int ndr_flags, NTTIME *t)
+{
+       NDR_CHECK(ndr_pull_udlong(ndr, ndr_flags, t));
+       return NT_STATUS_OK;
+}
 
 /*
-  push a general string onto the wire
+  push a NTTIME
 */
-NTSTATUS ndr_push_string(struct ndr_push *ndr, int ndr_flags, const char *s)
+_PUBLIC_ NTSTATUS ndr_push_NTTIME_1sec(struct ndr_push *ndr, int ndr_flags, NTTIME t)
 {
-       ssize_t s_len, c_len;
-       int ret;
+       t /= 10000000;
+       NDR_CHECK(ndr_push_hyper(ndr, ndr_flags, t));
+       return NT_STATUS_OK;
+}
 
-       if (!(ndr_flags & NDR_SCALARS)) {
-               return NT_STATUS_OK;
-       }
-       
-       s_len = s?strlen(s):0;
-       c_len = s?strlen_m(s):0;
-
-       switch (ndr->flags & LIBNDR_STRING_FLAGS) {
-       case LIBNDR_FLAG_STR_LEN4|LIBNDR_FLAG_STR_SIZE4:
-               NDR_CHECK(ndr_push_uint32(ndr, c_len+1));
-               NDR_CHECK(ndr_push_uint32(ndr, 0));
-               NDR_CHECK(ndr_push_uint32(ndr, c_len+1));
-               NDR_PUSH_NEED_BYTES(ndr, c_len*2 + 2);
-               ret = convert_string(CH_UNIX, CH_UCS2, 
-                                    s, s_len+1,
-                                    ndr->data+ndr->offset, c_len*2 + 2);
-               if (ret == -1) {
-                       return ndr_push_error(ndr, NDR_ERR_CHARCNV, 
-                                             "Bad character conversion");
-               }
-               ndr->offset += c_len*2 + 2;
-               break;
-
-       case LIBNDR_FLAG_STR_LEN4|LIBNDR_FLAG_STR_SIZE4|LIBNDR_FLAG_STR_NOTERM:
-               NDR_CHECK(ndr_push_uint32(ndr, c_len));
-               NDR_CHECK(ndr_push_uint32(ndr, 0));
-               NDR_CHECK(ndr_push_uint32(ndr, c_len));
-               NDR_PUSH_NEED_BYTES(ndr, c_len*2);
-               ret = convert_string(CH_UNIX, CH_UCS2, 
-                                    s, s_len,
-                                    ndr->data+ndr->offset, c_len*2);
-               if (ret == -1) {
-                       return ndr_push_error(ndr, NDR_ERR_CHARCNV, 
-                                             "Bad character conversion");
-               }
-               ndr->offset += c_len*2;
-               break;
-
-       case LIBNDR_FLAG_STR_SIZE4:
-               NDR_CHECK(ndr_push_uint32(ndr, c_len + 1));
-               NDR_PUSH_NEED_BYTES(ndr, c_len*2 + 2);
-               ret = convert_string(CH_UNIX, CH_UCS2, 
-                                    s, s_len + 1,
-                                    ndr->data+ndr->offset, c_len*2 + 2);
-               if (ret == -1) {
-                       return ndr_push_error(ndr, NDR_ERR_CHARCNV, 
-                                             "Bad character conversion");
-               }
-               ndr->offset += c_len*2 + 2;
-               break;
-
-       case LIBNDR_FLAG_STR_NULLTERM:
-               NDR_PUSH_NEED_BYTES(ndr, c_len*2 + 2);
-               ret = convert_string(CH_UNIX, CH_UCS2, 
-                                    s, s_len+1,
-                                    ndr->data+ndr->offset, c_len*2 + 2);
-               if (ret == -1) {
-                       return ndr_push_error(ndr, NDR_ERR_CHARCNV, 
-                                             "Bad character conversion");
-               }
-               ndr->offset += c_len*2 + 2;
-               break;
-               
-       case LIBNDR_FLAG_STR_ASCII|LIBNDR_FLAG_STR_LEN4|LIBNDR_FLAG_STR_SIZE4:
-               NDR_CHECK(ndr_push_uint32(ndr, c_len+1));
-               NDR_CHECK(ndr_push_uint32(ndr, 0));
-               NDR_CHECK(ndr_push_uint32(ndr, c_len+1));
-               NDR_PUSH_NEED_BYTES(ndr, c_len + 1);
-               ret = convert_string(CH_UNIX, CH_DOS, 
-                                    s, s_len + 1,
-                                    ndr->data+ndr->offset, c_len + 1);
-               if (ret == -1) {
-                       return ndr_push_error(ndr, NDR_ERR_CHARCNV, 
-                                             "Bad character conversion");
-               }
-               ndr->offset += c_len + 1;
-               break;
-
-       case LIBNDR_FLAG_STR_ASCII|LIBNDR_FLAG_STR_LEN4:
-               NDR_CHECK(ndr_push_uint32(ndr, 0));
-               NDR_CHECK(ndr_push_uint32(ndr, c_len+1));
-               NDR_PUSH_NEED_BYTES(ndr, c_len + 1);
-               ret = convert_string(CH_UNIX, CH_DOS, 
-                                    s, s_len + 1,
-                                    ndr->data+ndr->offset, c_len + 1);
-               if (ret == -1) {
-                       return ndr_push_error(ndr, NDR_ERR_CHARCNV, 
-                                             "Bad character conversion");
-               }
-               ndr->offset += c_len + 1;
-               break;
+/*
+  pull a NTTIME_1sec
+*/
+_PUBLIC_ NTSTATUS ndr_pull_NTTIME_1sec(struct ndr_pull *ndr, int ndr_flags, NTTIME *t)
+{
+       NDR_CHECK(ndr_pull_hyper(ndr, ndr_flags, t));
+       (*t) *= 10000000;
+       return NT_STATUS_OK;
+}
 
-       default:
-               return ndr_push_error(ndr, NDR_ERR_STRING, "Bad string flags 0x%x\n",
-                                     ndr->flags & LIBNDR_STRING_FLAGS);
-       }
+/*
+  pull a NTTIME_hyper
+*/
+_PUBLIC_ NTSTATUS ndr_pull_NTTIME_hyper(struct ndr_pull *ndr, int ndr_flags, NTTIME *t)
+{
+       NDR_CHECK(ndr_pull_hyper(ndr, ndr_flags, t));
+       return NT_STATUS_OK;
+}
 
+/*
+  push a NTTIME_hyper
+*/
+_PUBLIC_ NTSTATUS ndr_push_NTTIME_hyper(struct ndr_push *ndr, int ndr_flags, NTTIME t)
+{
+       NDR_CHECK(ndr_push_hyper(ndr, ndr_flags, t));
        return NT_STATUS_OK;
 }
 
 /*
-  push a 4 byte offset pointer, remembering where we are so we can later fill
-  in the correct value
+  push a time_t
 */
-NTSTATUS ndr_push_offset(struct ndr_push *ndr, struct ndr_push_save *ofs)
+_PUBLIC_ NTSTATUS ndr_push_time_t(struct ndr_push *ndr, int ndr_flags, time_t t)
 {
-       NDR_PUSH_ALIGN(ndr, 4);
-       ndr_push_save(ndr, ofs);
-       return ndr_push_uint32(ndr, 0);
+       return ndr_push_uint32(ndr, ndr_flags, t);
 }
 
 /*
-  fill in the correct offset in a saved offset pointer
-  the offset is taken relative to 'save'
+  pull a time_t
 */
-NTSTATUS ndr_push_offset_ptr(struct ndr_push *ndr, 
-                            struct ndr_push_save *ofs, 
-                            struct ndr_push_save *save)
+_PUBLIC_ NTSTATUS ndr_pull_time_t(struct ndr_pull *ndr, int ndr_flags, time_t *t)
 {
-       struct ndr_push_save save2;
-       ndr_push_save(ndr, &save2);
-       ndr_push_restore(ndr, ofs);
-       NDR_CHECK(ndr_push_uint32(ndr, save2.offset - save->offset));
-       ndr_push_restore(ndr, &save2);
+       uint32_t tt;
+       NDR_CHECK(ndr_pull_uint32(ndr, ndr_flags, &tt));
+       *t = tt;
        return NT_STATUS_OK;
 }
 
 
 /*
-  push a GUID
+  pull a ipv4address
 */
-NTSTATUS ndr_push_GUID(struct ndr_push *ndr, int ndr_flags, GUID *guid)
+_PUBLIC_ NTSTATUS ndr_pull_ipv4address(struct ndr_pull *ndr, int ndr_flags, const char **address)
 {
-       if (ndr_flags & NDR_SCALARS) {
-               return ndr_push_bytes(ndr, guid->info, GUID_SIZE);
-       }
+       struct ipv4_addr in;
+       NDR_CHECK(ndr_pull_uint32(ndr, ndr_flags, &in.addr));
+       in.addr = htonl(in.addr);
+       *address = talloc_strdup(ndr->current_mem_ctx, sys_inet_ntoa(in));
+       NT_STATUS_HAVE_NO_MEMORY(*address);
        return NT_STATUS_OK;
 }
 
 /*
-  push a NTTIME
+  push a ipv4address
 */
-NTSTATUS ndr_push_NTTIME(struct ndr_push *ndr, NTTIME t)
+_PUBLIC_ NTSTATUS ndr_push_ipv4address(struct ndr_push *ndr, int ndr_flags, const char *address)
 {
-       NDR_CHECK(ndr_push_uint32(ndr, t.low));
-       NDR_CHECK(ndr_push_uint32(ndr, t.high));
+       uint32_t addr;
+       if (!is_ipaddress(address)) {
+               return ndr_push_error(ndr, NDR_ERR_IPV4ADDRESS,
+                                     "Invalid IPv4 address: '%s'", 
+                                     address);
+       }
+       addr = inet_addr(address);
+       NDR_CHECK(ndr_push_uint32(ndr, ndr_flags, htonl(addr)));
        return NT_STATUS_OK;
 }
 
 /*
-  pull a NTTIME
+  print a ipv4address
 */
-NTSTATUS ndr_pull_NTTIME(struct ndr_pull *ndr, NTTIME *t)
+_PUBLIC_ void ndr_print_ipv4address(struct ndr_print *ndr, const char *name, 
+                          const char *address)
 {
-       NDR_CHECK(ndr_pull_uint32(ndr, &t->low));
-       NDR_CHECK(ndr_pull_uint32(ndr, &t->high));
-       return NT_STATUS_OK;
+       ndr->print(ndr, "%-25s: %s", name, address);
 }
 
 
-void ndr_print_struct(struct ndr_print *ndr, const char *name, const char *type)
+_PUBLIC_ void ndr_print_struct(struct ndr_print *ndr, const char *name, const char *type)
 {
        ndr->print(ndr, "%s: struct %s", name, type);
 }
 
-void ndr_print_uint8(struct ndr_print *ndr, const char *name, uint8 v)
+_PUBLIC_ void ndr_print_enum(struct ndr_print *ndr, const char *name, const char *type, 
+                   const char *val, uint_t value)
+{
+       if (ndr->flags & LIBNDR_PRINT_ARRAY_HEX) {
+               ndr->print(ndr, "%-25s: %s (0x%X)", name, val?val:"UNKNOWN_ENUM_VALUE", value);
+       } else {
+               ndr->print(ndr, "%-25s: %s (%d)", name, val?val:"UNKNOWN_ENUM_VALUE", value);
+       }
+}
+
+_PUBLIC_ void ndr_print_bitmap_flag(struct ndr_print *ndr, size_t size, const char *flag_name, uint_t flag, uint_t value)
+{
+       /* this is an attempt to support multi-bit bitmap masks */
+       value &= flag;
+
+       while (!(flag & 1)) {
+               flag >>= 1;
+               value >>= 1;
+       }       
+       if (flag == 1) {
+               ndr->print(ndr, "   %d: %-25s", value, flag_name);
+       } else {
+               ndr->print(ndr, "0x%02x: %-25s (%d)", value, flag_name, value);
+       }
+}
+
+_PUBLIC_ void ndr_print_int8(struct ndr_print *ndr, const char *name, int8_t v)
+{
+       ndr->print(ndr, "%-25s: %d", name, v);
+}
+
+_PUBLIC_ void ndr_print_uint8(struct ndr_print *ndr, const char *name, uint8_t v)
 {
        ndr->print(ndr, "%-25s: 0x%02x (%u)", name, v, v);
 }
 
-void ndr_print_uint16(struct ndr_print *ndr, const char *name, uint16 v)
+_PUBLIC_ void ndr_print_int16(struct ndr_print *ndr, const char *name, int16_t v)
+{
+       ndr->print(ndr, "%-25s: %d", name, v);
+}
+
+_PUBLIC_ void ndr_print_uint16(struct ndr_print *ndr, const char *name, uint16_t v)
 {
        ndr->print(ndr, "%-25s: 0x%04x (%u)", name, v, v);
 }
 
-void ndr_print_uint32(struct ndr_print *ndr, const char *name, uint32 v)
+_PUBLIC_ void ndr_print_int32(struct ndr_print *ndr, const char *name, int32_t v)
+{
+       ndr->print(ndr, "%-25s: %d", name, v);
+}
+
+_PUBLIC_ void ndr_print_uint32(struct ndr_print *ndr, const char *name, uint32_t v)
 {
        ndr->print(ndr, "%-25s: 0x%08x (%u)", name, v, v);
 }
 
-void ndr_print_HYPER_T(struct ndr_print *ndr, const char *name, HYPER_T v)
+_PUBLIC_ void ndr_print_udlong(struct ndr_print *ndr, const char *name, uint64_t v)
+{
+       ndr->print(ndr, "%-25s: 0x%016llx (%llu)", name, v, v);
+}
+
+_PUBLIC_ void ndr_print_udlongr(struct ndr_print *ndr, const char *name, uint64_t v)
+{
+       ndr_print_udlong(ndr, name, v);
+}
+
+_PUBLIC_ void ndr_print_dlong(struct ndr_print *ndr, const char *name, int64_t v)
 {
-       ndr->print(ndr, "%-25s: 0x%08x%08x", name, v.high, v.low);
+       ndr->print(ndr, "%-25s: 0x%016llx (%lld)", name, v, v);
 }
 
-void ndr_print_ptr(struct ndr_print *ndr, const char *name, const void *p)
+_PUBLIC_ void ndr_print_hyper(struct ndr_print *ndr, const char *name, uint64_t v)
+{
+       ndr_print_dlong(ndr, name, v);
+}
+
+_PUBLIC_ void ndr_print_pointer(struct ndr_print *ndr, const char *name, void *v)
+{
+       ndr->print(ndr, "%-25s: %p", name, v);
+}
+
+_PUBLIC_ void ndr_print_ptr(struct ndr_print *ndr, const char *name, const void *p)
 {
        if (p) {
                ndr->print(ndr, "%-25s: *", name);
@@ -643,53 +712,62 @@ void ndr_print_ptr(struct ndr_print *ndr, const char *name, const void *p)
        }
 }
 
-void ndr_print_string(struct ndr_print *ndr, const char *name, const char *s)
+_PUBLIC_ void ndr_print_NTTIME(struct ndr_print *ndr, const char *name, NTTIME t)
 {
-       if (s) {
-               ndr->print(ndr, "%-25s: '%s'", name, s);
-       } else {
-               ndr->print(ndr, "%-25s: NULL", name);
-       }
+       ndr->print(ndr, "%-25s: %s", name, nt_time_string(ndr, t));
 }
 
-void ndr_print_NTTIME(struct ndr_print *ndr, const char *name, NTTIME t)
+_PUBLIC_ void ndr_print_NTTIME_1sec(struct ndr_print *ndr, const char *name, NTTIME t)
 {
-       ndr->print(ndr, "%-25s: %s", name, nt_time_string(ndr->mem_ctx, &t));
+       /* this is a standard NTTIME here
+        * as it's already converted in the pull/push code
+        */
+       ndr_print_NTTIME(ndr, name, t);
 }
 
-void ndr_print_union(struct ndr_print *ndr, const char *name, uint16 level, const char *type)
+_PUBLIC_ void ndr_print_NTTIME_hyper(struct ndr_print *ndr, const char *name, NTTIME t)
 {
-       ndr->print(ndr, "%-25s: union %s(case %u)", name, type, level);
+       ndr_print_NTTIME(ndr, name, t);
 }
 
-void ndr_print_bad_level(struct ndr_print *ndr, const char *name, uint16 level)
+_PUBLIC_ void ndr_print_time_t(struct ndr_print *ndr, const char *name, time_t t)
 {
-       ndr->print(ndr, "UNKNOWN LEVEL %u", level);
+       if (t == (time_t)-1 || t == 0) {
+               ndr->print(ndr, "%-25s: (time_t)%d", name, (int)t);
+       } else {
+               ndr->print(ndr, "%-25s: %s", name, timestring(ndr, t));
+       }
 }
 
-void ndr_print_array_uint32(struct ndr_print *ndr, const char *name, 
-                           const uint32 *data, uint32 count)
+_PUBLIC_ void ndr_print_union(struct ndr_print *ndr, const char *name, int level, const char *type)
 {
-       int i;
-
-       ndr->print(ndr, "%s: ARRAY(%d)", name, count);
-       ndr->depth++;
-       for (i=0;i<count;i++) {
-               char *idx=NULL;
-               asprintf(&idx, "[%d]", i);
-               if (idx) {
-                       ndr_print_uint32(ndr, idx, data[i]);
-                       free(idx);
-               }
+       if (ndr->flags & LIBNDR_PRINT_ARRAY_HEX) {
+               ndr->print(ndr, "%-25s: union %s(case 0x%X)", name, type, level);
+       } else {
+               ndr->print(ndr, "%-25s: union %s(case %d)", name, type, level);
        }
-       ndr->depth--;   
 }
 
-void ndr_print_array_uint8(struct ndr_print *ndr, const char *name, 
-                          const uint8 *data, uint32 count)
+_PUBLIC_ void ndr_print_bad_level(struct ndr_print *ndr, const char *name, uint16_t level)
+{
+       ndr->print(ndr, "UNKNOWN LEVEL %u", level);
+}
+
+_PUBLIC_ void ndr_print_array_uint8(struct ndr_print *ndr, const char *name, 
+                          const uint8_t *data, uint32_t count)
 {
        int i;
 
+       if (count <= 600 && (ndr->flags & LIBNDR_PRINT_ARRAY_HEX)) {
+               char s[1202];
+               for (i=0;i<count;i++) {
+                       snprintf(&s[i*2], 3, "%02x", data[i]);
+               }
+               s[i*2] = 0;
+               ndr->print(ndr, "%-25s: %s", name, s);
+               return;
+       }
+
        ndr->print(ndr, "%s: ARRAY(%d)", name, count);
        ndr->depth++;
        for (i=0;i<count;i++) {
@@ -703,28 +781,33 @@ void ndr_print_array_uint8(struct ndr_print *ndr, const char *name,
        ndr->depth--;   
 }
 
-void ndr_print_GUID(struct ndr_print *ndr, const char *name, const struct GUID *guid)
-{
-       ndr->print(ndr, "%-25s: %08x-%04x-%04x-%02x%02x-%02x%02x%02x%02x%02x%02x", 
-                  name,
-                  IVAL(guid->info, 0), SVAL(guid->info, 4), SVAL(guid->info, 6),
-                  guid->info[8], guid->info[9],
-                  guid->info[10], guid->info[11], guid->info[12], guid->info[13], 
-                  guid->info[14], guid->info[15]);
-}
-
-void ndr_print_DATA_BLOB(struct ndr_print *ndr, const char *name, DATA_BLOB r)
+_PUBLIC_ void ndr_print_DATA_BLOB(struct ndr_print *ndr, const char *name, DATA_BLOB r)
 {
        ndr->print(ndr, "%-25s: DATA_BLOB length=%u", name, r.length);
+       if (r.length) {
+               dump_data(10, r.data, r.length);
+       }
 }
 
 
 /*
   push a DATA_BLOB onto the wire. 
 */
-NTSTATUS ndr_push_DATA_BLOB(struct ndr_push *ndr, DATA_BLOB blob)
+_PUBLIC_ NTSTATUS ndr_push_DATA_BLOB(struct ndr_push *ndr, int ndr_flags, DATA_BLOB blob)
 {
-       NDR_CHECK(ndr_push_uint32(ndr, blob.length));
+       if (ndr->flags & LIBNDR_ALIGN_FLAGS) {
+               if (ndr->flags & LIBNDR_FLAG_ALIGN2) {
+                       blob.length = NDR_ALIGN(ndr, 2);
+               } else if (ndr->flags & LIBNDR_FLAG_ALIGN4) {
+                       blob.length = NDR_ALIGN(ndr, 4);
+               } else if (ndr->flags & LIBNDR_FLAG_ALIGN8) {
+                       blob.length = NDR_ALIGN(ndr, 8);
+               }
+               NDR_PUSH_ALLOC_SIZE(ndr, blob.data, blob.length);
+               data_blob_clear(&blob);
+       } else if (!(ndr->flags & LIBNDR_FLAG_REMAINING)) {
+               NDR_CHECK(ndr_push_uint32(ndr, NDR_SCALARS, blob.length));
+       }
        NDR_CHECK(ndr_push_bytes(ndr, blob.data, blob.length));
        return NT_STATUS_OK;
 }
@@ -732,23 +815,33 @@ NTSTATUS ndr_push_DATA_BLOB(struct ndr_push *ndr, DATA_BLOB blob)
 /*
   pull a DATA_BLOB from the wire. 
 */
-NTSTATUS ndr_pull_DATA_BLOB(struct ndr_pull *ndr, DATA_BLOB *blob)
+_PUBLIC_ NTSTATUS ndr_pull_DATA_BLOB(struct ndr_pull *ndr, int ndr_flags, DATA_BLOB *blob)
 {
-       uint32 length;
-       NDR_CHECK(ndr_pull_uint32(ndr, &length));
+       uint32_t length;
+
+       if (ndr->flags & LIBNDR_ALIGN_FLAGS) {
+               if (ndr->flags & LIBNDR_FLAG_ALIGN2) {
+                       length = NDR_ALIGN(ndr, 2);
+               } else if (ndr->flags & LIBNDR_FLAG_ALIGN4) {
+                       length = NDR_ALIGN(ndr, 4);
+               } else if (ndr->flags & LIBNDR_FLAG_ALIGN8) {
+                       length = NDR_ALIGN(ndr, 8);
+               }
+               if (ndr->data_size - ndr->offset < length) {
+                       length = ndr->data_size - ndr->offset;
+               }
+       } else if (ndr->flags & LIBNDR_FLAG_REMAINING) {
+               length = ndr->data_size - ndr->offset;
+       } else {
+               NDR_CHECK(ndr_pull_uint32(ndr, NDR_SCALARS, &length));
+       }
        NDR_PULL_NEED_BYTES(ndr, length);
-       *blob = data_blob_talloc(ndr->mem_ctx, ndr->data+ndr->offset, length);
+       *blob = data_blob_talloc(ndr->current_mem_ctx, ndr->data+ndr->offset, length);
        ndr->offset += length;
        return NT_STATUS_OK;
 }
 
-
-void ndr_print_policy_handle(struct ndr_print *ndr, const char *name, struct policy_handle *r)
+_PUBLIC_ uint32_t ndr_size_DATA_BLOB(int ret, const DATA_BLOB *data, int flags)
 {
-       ndr->print(ndr, "%-25s: policy_handle %02x%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x", 
-                  name, 
-                  r->data[0], r->data[1], r->data[2], r->data[3], r->data[4], 
-                  r->data[5], r->data[6], r->data[7], r->data[8], r->data[9], 
-                  r->data[10], r->data[11], r->data[12], r->data[13], r->data[14], 
-                  r->data[15], r->data[16], r->data[17], r->data[18], r->data[19]);
+       return ret + data->length;
 }